Enterprise web programming

Units ENTWA (Level 6) and APSW (Level 7)

Feedback on APSW SWS 1 2012-2013

Jim Briggs

Task B

Task B was generally carried out competently, but obviously some groups implemented more functionality than others, and no group implemented everything.

I was especially pleased with the way that ALL groups mastered JPA and EJB.

Comments about the structure and readability of the code have been made on the submitted printouts. See those (available from the office next term) for further feedback.

Note that these marks are provisional until approved by a Unit Assessment Board.

Common issues

Group A

Category

Out of

Mark

Comments

Overall functionality

10

4

Not a lot working.

Input validation

5

2

Very poor. Does not match spec.

User interface utility

5

2

Not fully working. Invalid XHTML in some pages.

Entity and relationship storage

10

5

What does entity "Aeroplane" add? I don't understand why the @Column annotation needs to be used when you are not using a legacy database.

Structure of classes within tiers

5

2

Built from too many components, which confuses the structure. Why do you need so many interfaces and why are some implemented twice?

Quality of code written

15

7

Why does every field name have to start with an "m"? Poorly formatted.

TOTAL

50

22

Terribly over-complicated in parts. Rather poor.

Group B

Category

Out of

Mark

Comments

Overall functionality

10

5

Some functionality. Able to add flights, but not make a booking.

Input validation

5

4

Need error messages next to location of error.

User interface utility

5

3

OK, but did not make use easy.

Entity and relationship storage

10

7

Correct entities and facades, but little functionality.

Structure of classes within tiers

5

4

Neatly structured, but not as much quantity of code in the business layer as I would expect.

Quality of code written

15

8

Package "validators" should be "groupb.validators" (at least). A few formatting foibles.

TOTAL

50

31

A reasonable attempt, but need to focus on delivering functionality.

Group C

Category

Out of

Mark

Comments

Overall functionality

10

6

I thought I had made a booking, but it turned out it did nothing. (createBooking is never called!) Adding other entities seems to work.

Input validation

5

3.5

Fails validation of phone number (due to failure to allow for spaces). Cannot verify validation of booking details.

User interface utility

5

4

Error: "countryairport: Validation Error: Value is required." when I click on "Back to add passenger".

Entity and relationship storage

10

8

Good, though the names of the methods in BookingFacade are not very self-documenting.

Structure of classes within tiers

5

4

AbstractFacade should not be in "AirlineBooking.Entities". Otherwise OK.

Quality of code written

15

10

Package names should have initial lower case names. Conventionally, only classes (and interfaces) start with an upper case letter.

TOTAL

50

35.5

A good attempt, though need to test all the functionality.

Group D

Category

Out of

Mark

Comments

Overall functionality

10

       6.5

Got the message "j_idt6:passengerPerFlight:0:j_idt35: Could not convert '12/18/12 4:08 PM' to a string." when trying to make a second booking. "back to flights list" did not work. Never more than 1 flight on flight list.

Input validation

5

3

Failed validation of phone number  and postcode (need to allow for spaces). Were all the validator classes necessary?

User interface utility

5

4

Best user interface, but some broken links.

Entity and relationship storage

10

9

Appropriate use of named queries. Good use of entities and facades. Good (though unsuccessful) try to initialise database with an application listener.

Structure of classes within tiers

5

4

OK, but with this many packages you may need to use a hierarchy. Not as much quantity of code in the business layer as I would expect.

Quality of code written

15

11

In business methods, for clarity put the two statements that assign a bi-directional relationship next to each other.

TOTAL

50

37.5

A good attempt though needed a bit more testing.

 

Last updated by Prof Jim Briggs of the School of Computing at the University of Portsmouth

 
The enterprise web programming units include some material that was formerly part of the WEB1P and WEB2P units.