Category

Out of

Mark

Comments

Overall functionality

10

6

Reasonable stab at getting most things working

Input validation

5

2.5

Replication in a lot of JSPs – why not put common code in a .js file? Even better would be to only need 1 JSP for all data entry/edit.

Search mechanism

5

2.5

Overly complicated by the decision not to use MVC2.

Updating mechanism

5

2.5

Ditto.

Entry storage

5

2

Bad decision to store time as String – database more than capable of storing date/time values.

Appropriate use of object-oriented programming features and tools

10

5

Poor structure, partly due to non-use of MVC2.

Maintainability and readability of code

10

5

Ditto. Use of scriptlets in JSPs is seriously deprecated.

TOTAL

50

25.5

Category

Out of

Mark

Comments

Overall functionality

10

6

Reasonable stab at getting most things working

Input validation

5

3

Good on server side, but too much replication on client side – why not put common code in a .js file? Even better would be to only need 1 JSP for all data entry/edit.

Search mechanism

5

2.5

Complex SQL. Would have been a lot simpler in HQL.

Updating mechanism

5

2.5

Need to establish clear demarcation between business logic and persistence code.

Entry storage

5

2.5

Ditto

Appropriate use of object-oriented programming features and tools

10

6

Though I suspect you only got this because I showed you!

Maintainability and readability of code

10

5

Some overly complex code due to in appropriate classes.

TOTAL

50

27.5