Web programming

Units WEB1P and WEB2P

Feedback on WEB1P SWS semester 1 2011-2012

Task B

Task B was generally carried out competently, but obviously some groups implemented more functionality than others, and no group implemented everything.
Comments about the structure and readability of the code have been made on the submitted printouts. See those for further feedback.

Group A

Category

Out of

Mark

Comments

Overall functionality

10

4

Only a small subset of functionality actually working

Input validation

10

7

Satisfactory, but some rules are overly restrictive which detracts from usability.

User interface utility

5

2

Basic. Not all functionality yet available in the user interface.

Entity and relationship storage

10

4

Although your existing entities are OK, you've largely missed the point about JPA, which is that it will automatically update all managed objects for you. You must have an entity "Booking".

Quality of code written

15

7

"ValidateServ" and "AdminLog" are among many poorly chosen identifiers. Server-side validation code could be much more concise.

TOTAL

50

24

A reasonable attempt, but I think you spent too much time on some aspects that didn't map into marks, perhaps because you didn't have time to integrate them at the end.

Group B

Category

Out of

Mark

Comments

Overall functionality

10

5

Did not appear to create any sample flights! NullPointerException when tried to book without any flights to select. Faulty logic can result in duplicate passengers being added to database. Faulty logic in creating new booking.

Input validation

10

7

Satisfactory, but not all rules implemented correctly (e.g. phone numbers).

User interface utility

5

3

Primefaces makes it relatively easy to make the UI look good, but also think about the usability.

Entity and relationship storage

10

7

Avoid @Table and @Column annotations (even if wizard creates them for you) if not necessary. Mix ups between layers of model (all code that uses an EntityManager should be in the façade classes).

Quality of code written

15

10

No root package (e.g. groupb.sws) for code. Java convention is for all class names to start with Capital.

TOTAL

50

32

Good use of JSF and Primefaces, but flaws in the logic at lower levels.

Group C

Category

Out of

Mark

Comments

Overall functionality

10

5

Not much functionality implemented. Can't see any way of making a booking.

Input validation

10

4

No client-side validation apparent. Rules for flight numbers and phone numbers not implemented accurately.

User interface utility

5

3

Primefaces makes it relatively easy to make the UI look good, but also think about the usability.

Entity and relationship storage

10

6

Flight.departureDate should be a Date not a String. No business logic classes. Relationships handled appropriately.

Quality of code written

15

10

Code very clear. Root package (justin) for some of the code but not all.

TOTAL

50

28

A reasonable attempt, but missing crucial business logic.

 

Last updated by Prof Jim Briggs of the School of Computing at the University of Portsmouth

 
The web programming units include some material that was formerly part of the WPRMP, WECPP, WPSSM and WEMAM units.